Hide CRF input when lossless quality is selected

This commit is contained in:
Stu Leak 2025-12-20 14:47:47 -05:00
parent 406709bec6
commit 2dae75dd8e
3 changed files with 10 additions and 0 deletions

View File

@ -774,6 +774,7 @@ This file tracks completed features, fixes, and milestones.
- ✅ Fixed stats bar updates to run on the UI thread to avoid Fyne warnings - ✅ Fixed stats bar updates to run on the UI thread to avoid Fyne warnings
- ✅ Defaulted Target Aspect Ratio back to Source unless user explicitly sets it - ✅ Defaulted Target Aspect Ratio back to Source unless user explicitly sets it
- ✅ Synced Target Aspect Ratio between Simple and Advanced menus - ✅ Synced Target Aspect Ratio between Simple and Advanced menus
- ✅ Hide manual CRF input when Lossless quality is selected
- ✅ Stabilized video seeking and embedded rendering - ✅ Stabilized video seeking and embedded rendering
- ✅ Improved player window positioning - ✅ Improved player window positioning
- ✅ Fixed clear video functionality - ✅ Fixed clear video functionality

View File

@ -48,6 +48,7 @@ This file tracks upcoming features, improvements, and known issues.
- Stats bar updates run on the UI thread - Stats bar updates run on the UI thread
- Target aspect default enforced as Source unless user changes it - Target aspect default enforced as Source unless user changes it
- Target aspect sync across simple/advanced menus - Target aspect sync across simple/advanced menus
- Hide manual CRF entry when Lossless quality is active
## Priority Features for dev20+ ## Priority Features for dev20+

View File

@ -6581,6 +6581,7 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
updateQualityVisibility = func() { updateQualityVisibility = func() {
hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") || hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") ||
strings.EqualFold(state.convert.VideoCodec, "H.265") strings.EqualFold(state.convert.VideoCodec, "H.265")
hideCRF := strings.EqualFold(state.convert.Quality, "Lossless")
if qualitySectionSimple != nil { if qualitySectionSimple != nil {
if hide { if hide {
@ -6596,6 +6597,13 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
qualitySectionAdv.Show() qualitySectionAdv.Show()
} }
} }
if crfContainer != nil {
if hideCRF {
crfContainer.Hide()
} else {
crfContainer.Show()
}
}
} }
// Simple mode options - minimal controls, aspect locked to Source // Simple mode options - minimal controls, aspect locked to Source