From 2dae75dd8ef7f432c0333f181c81f80f26f35b45 Mon Sep 17 00:00:00 2001 From: Stu Leak Date: Sat, 20 Dec 2025 14:47:47 -0500 Subject: [PATCH] Hide CRF input when lossless quality is selected --- DONE.md | 1 + TODO.md | 1 + main.go | 8 ++++++++ 3 files changed, 10 insertions(+) diff --git a/DONE.md b/DONE.md index 236fdf3..4861b10 100644 --- a/DONE.md +++ b/DONE.md @@ -774,6 +774,7 @@ This file tracks completed features, fixes, and milestones. - ✅ Fixed stats bar updates to run on the UI thread to avoid Fyne warnings - ✅ Defaulted Target Aspect Ratio back to Source unless user explicitly sets it - ✅ Synced Target Aspect Ratio between Simple and Advanced menus +- ✅ Hide manual CRF input when Lossless quality is selected - ✅ Stabilized video seeking and embedded rendering - ✅ Improved player window positioning - ✅ Fixed clear video functionality diff --git a/TODO.md b/TODO.md index 035188e..1a1ef22 100644 --- a/TODO.md +++ b/TODO.md @@ -48,6 +48,7 @@ This file tracks upcoming features, improvements, and known issues. - Stats bar updates run on the UI thread - Target aspect default enforced as Source unless user changes it - Target aspect sync across simple/advanced menus + - Hide manual CRF entry when Lossless quality is active ## Priority Features for dev20+ diff --git a/main.go b/main.go index 0914b42..cda3498 100644 --- a/main.go +++ b/main.go @@ -6581,6 +6581,7 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject { updateQualityVisibility = func() { hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") || strings.EqualFold(state.convert.VideoCodec, "H.265") + hideCRF := strings.EqualFold(state.convert.Quality, "Lossless") if qualitySectionSimple != nil { if hide { @@ -6596,6 +6597,13 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject { qualitySectionAdv.Show() } } + if crfContainer != nil { + if hideCRF { + crfContainer.Hide() + } else { + crfContainer.Show() + } + } } // Simple mode options - minimal controls, aspect locked to Source