leak_technologies/VideoTools
1
0
Fork 0
Code Issues 23 Pull requests Projects Releases 19 Packages Wiki Activity Actions

Code quality: errors silently discarded in 4 locations #37

New issue
Open
opened 2026-04-04 17:51:04 +00:00 by stu · 0 comments
stu commented 2026-04-04 17:51:04 +00:00
Owner
Copy link

Locations

  1. internal/dvd/vob/sri.go:70 � io.ReadFull error discarded silently; corrupted SPU data may go undetected
  2. internal/player/gstreamer_player.go:269 � seek error explicitly discarded with no log entry
  3. internal/queue/edit.go:139-144, 192-197 � JSON marshal errors silently ignored; config changes may be lost
  4. internal/convert/dvd.go:155-163 � fmt.Sscanf parse error ignored; bad timecode may cause wrong chapter placement

Fix

Replace discards with logging.Debug(logging.CatXxx, ...) calls at minimum. Errors that affect output quality (sri.go, dvd.go) should propagate to the caller.

## Locations 1. `internal/dvd/vob/sri.go:70` � `io.ReadFull` error discarded silently; corrupted SPU data may go undetected 2. `internal/player/gstreamer_player.go:269` � seek error explicitly discarded with no log entry 3. `internal/queue/edit.go:139-144, 192-197` � JSON marshal errors silently ignored; config changes may be lost 4. `internal/convert/dvd.go:155-163` � `fmt.Sscanf` parse error ignored; bad timecode may cause wrong chapter placement ## Fix Replace discards with `logging.Debug(logging.CatXxx, ...)` calls at minimum. Errors that affect output quality (sri.go, dvd.go) should propagate to the caller.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v0.1.1-dev48
v0.1.1-dev47
v0.1.1-dev46
v0.1.1-dev45
v0.1.1-dev44
v0.1.1-dev43
v0.1.1-dev42
v0.1.1-dev41
v0.1.1-dev40
v0.1.1-dev39
v0.1.1-dev38
v0.1.1-dev37
v0.1.1-dev36
v0.1.1-dev35
v0.1.1-dev34
v0.1.1-dev33
v0.1.1-dev32
v0.1.1-dev31
v0.1.1-dev29
v0.1.1-dev30
v0.1.1-dev28
v0.1.1-dev27
v0.1.1-dev26
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
leak_technologies/VideoTools#37
No description provided.