🎯 Major Improvements: • Unified FFmpeg Player: Rock-solid A/V sync with frame-accurate seeking • Import Standardization: Convert to absolute module imports across codebase • Build Fixes: Resolve critical syntax errors and compilation issues • Code Cleanup: Remove unused code and fix variable references 🔧 Technical Changes: • Fixed pipe initialization in unified player (internal/player/unified_ffmpeg_player.go) • Replaced platformConfig references with utils.GetFFmpegPath() calls • Added platform-specific exec utilities (exec_unix.go, exec_windows.go) • Enhanced UI components with improved color handling • Fixed missing closing brace in buildMetadataPanel function 🐛 Critical Fixes: • Resolved "unexpected name buildVideoPane, expected (" syntax error • Fixed undefined variable references (start → sampleStart) • Removed calls to non-existent ColoredSelect Enable/Disable methods • Corrected import paths from relative to absolute module references 📊 Impact: +470 insertions, -951 deletions • Eliminates blocking A/V synchronization issues • Enables advanced video enhancement feature development • Establishes consistent module architecture • Codebase now builds and runs successfully This commit establishes the foundation for Phase 2 enhancement features by providing rock-solid video playback capabilities.
24 lines
1.0 KiB
Go
24 lines
1.0 KiB
Go
package utils
|
|
|
|
import (
|
|
"context"
|
|
"os/exec"
|
|
)
|
|
|
|
// CreateCommand is a platform-specific implementation for Unix-like systems (Linux, macOS).
|
|
// On these systems, external commands generally do not spawn new visible console windows
|
|
// unless explicitly configured to do so by the user's terminal environment.
|
|
// No special SysProcAttr is typically needed for console hiding on Unix.
|
|
func CreateCommand(ctx context.Context, name string, arg ...string) *exec.Cmd {
|
|
// For Unix-like systems, exec.CommandContext typically does not create a new console window.
|
|
// We just return the standard command.
|
|
return exec.CommandContext(ctx, name, arg...)
|
|
}
|
|
|
|
// CreateCommandRaw is a platform-specific implementation for Unix-like systems, without a context.
|
|
// No special SysProcAttr is typically needed for console hiding on Unix.
|
|
func CreateCommandRaw(name string, arg ...string) *exec.Cmd {
|
|
// For Unix-like systems, exec.Command typically does not create a new console window.
|
|
// We just return the standard command.
|
|
return exec.Command(name, arg...)
|
|
} |