Stu Leak
8f73913817
Issues Fixed:
1. Command Prompts During Benchmark
- Jake reported 4 command prompt windows appearing when opening benchmark
- Windows showing: C:\ffmpeg\bin\ffmpeg.exe for each hardware check
2. Wrong GPU Detection
- Jake's AMD R7 900 XTX not detected
- System incorrectly showing "13.50.53.699 Virtual Desktop" as GPU
- Showing "Monitor" instead of actual graphics card
Root Causes:
1. sysinfo package missing ApplyNoWindow() on Windows detection commands
- detectCPUWindows: wmic cpu query
- detectGPUWindows: nvidia-smi + wmic VideoController queries
- detectRAMWindows: wmic computersystem query
- These 3-4 calls showed command windows
2. GPU Detection Not Filtering Virtual Adapters
- wmic returns ALL video controllers (physical + virtual)
- Code was picking first entry which was virtual adapter
- No filtering for "Virtual Desktop", remote desktop adapters, etc.
Solutions:
1. Applied utils.ApplyNoWindow() to all Windows detection commands
- Hides wmic, nvidia-smi command windows
- Consistent with benchmark.go and platform.go patterns
- No-op on Linux/macOS (cross-platform safe)
2. Enhanced GPU Detection with Virtual Adapter Filtering
- Iterate through ALL video controllers from wmic
- Filter out virtual/software adapters:
* Virtual Desktop adapters
* Microsoft Basic Display Adapter
* Remote desktop (VNC, Parsec, TeamViewer)
- Return first physical GPU (AMD/NVIDIA/Intel)
- Debug logging shows skipped virtual adapters
Implementation:
- Import internal/utils in sysinfo package
- ApplyNoWindow() on 4 Windows commands:
* wmic cpu get name,maxclockspeed
* nvidia-smi --query-gpu=name,driver_version
* wmic path win32_VideoController get name,driverversion
* wmic computersystem get totalphysicalmemory
- Enhanced GPU parser with virtual adapter blacklist
- Debug logging for skipped/detected GPUs
Impact:
- No command windows during benchmark initialization (discreet operation)
- Correct physical GPU detection on systems with virtual adapters
- Should properly detect Jake's AMD R7 900 XTX
Files Changed:
- internal/sysinfo/sysinfo.go: ApplyNoWindow + GPU filtering
Reported-by: Jake (4 command prompts, wrong GPU detection)
Tested-on: Linux (build successful, no regressions)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| app | ||
| benchmark | ||
| convert | ||
| interlace | ||
| logging | ||
| metadata | ||
| modules | ||
| player | ||
| queue | ||
| sysinfo | ||
| thumbnail | ||
| ui | ||
| utils | ||