Compare commits

...

2 Commits

Author SHA1 Message Date
63539db36d Update DONE.md with player module crash fix
Documented disabling of Player module to prevent crashes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-28 20:33:21 -05:00
69a1cd5ba7 Disable Player module to prevent crashes (external dependency violation)
Issue:
- Player module was crashing when accessed
- Uses external tools (MPV, VLC, FFplay) which violates VideoTools' core principle
- Everything should be internal and lightweight, no external dependencies

Fix:
- Disabled Player module in main menu
- Module still exists in code but is not accessible to users
- Prevents crash by preventing access to broken functionality

Future work needed:
- Implement pure-Go internal player using FFmpeg libraries
- OR implement simple preview-only playback using existing preview system
- Must be self-contained and lightweight

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-28 20:33:07 -05:00
2 changed files with 8 additions and 1 deletions

View File

@ -4,6 +4,13 @@ This file tracks completed features, fixes, and milestones.
## Version 0.1.0-dev20+ (2025-12-28) - Queue UI Performance & Workflow Improvements
### Bug Fixes
- ✅ **Player Module Crash Fixed**
- Disabled Player module to prevent crashes
- Module was using external tools (MPV, VLC, FFplay) which violates VideoTools' self-contained principle
- Prevents access to broken functionality until proper internal implementation is added
- Future: Implement pure-Go internal player using FFmpeg libraries
### Workflow Enhancements
- ✅ **Benchmark Result Caching**
- Benchmark results now persist across app restarts

View File

@ -1618,7 +1618,7 @@ func (s *appState) showMainMenu() {
Label: m.Label,
Color: m.Color,
Category: m.Category,
Enabled: m.ID == "convert" || m.ID == "compare" || m.ID == "inspect" || m.ID == "merge" || m.ID == "thumb" || m.ID == "player" || m.ID == "filters" || m.ID == "upscale" || m.ID == "author" || m.ID == "subtitles" || m.ID == "rip", // Enabled modules
Enabled: m.ID == "convert" || m.ID == "compare" || m.ID == "inspect" || m.ID == "merge" || m.ID == "thumb" || m.ID == "filters" || m.ID == "upscale" || m.ID == "author" || m.ID == "subtitles" || m.ID == "rip", // Enabled modules (player disabled - requires internal implementation)
})
}