Leak_Technologies/VideoTools
Leak_Technologies/VideoTools
2
1
Fork 1
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity
680 Commits 1 Branch 20 Tags 340 MiB
127c19d48f
Commit Graph

4 Commits

Author SHA1 Message Date
Stu Leak
e5df961a41 fix: resolve build errors and complete dev22 fixes 
- Fixed syntax error in main.go formatBackground section
- Added formatContainer widget for format selection in Convert module
- Fixed forward declaration issues for updateDVDOptions and buildCommandPreview
- Added GPUVendor() method to sysinfo.HardwareInfo for GPU detection
- Implemented automatic GPU detection for hardware encoding (auto mode)
- Fixed JobTypeFilters -> JobTypeFilter naming inconsistency in queue.go
- Added proper JobType specifications to all queue constants
- Removed duplicate/conflicting types.go file

This fixes all compilation errors and completes the dev22 release readiness.
 2026-01-03 13:17:30 -05:00
Stu Leak
2ee220a694 fix(windows): Hide command windows in hardware detection and fix GPU detection 
Issues Fixed:
1. Command Prompts During Benchmark
   - Jake reported 4 command prompt windows appearing when opening benchmark
   - Windows showing: C:\ffmpeg\bin\ffmpeg.exe for each hardware check

2. Wrong GPU Detection
   - Jake's AMD R7 900 XTX not detected
   - System incorrectly showing "13.50.53.699 Virtual Desktop" as GPU
   - Showing "Monitor" instead of actual graphics card

Root Causes:
1. sysinfo package missing ApplyNoWindow() on Windows detection commands
   - detectCPUWindows: wmic cpu query
   - detectGPUWindows: nvidia-smi + wmic VideoController queries
   - detectRAMWindows: wmic computersystem query
   - These 3-4 calls showed command windows

2. GPU Detection Not Filtering Virtual Adapters
   - wmic returns ALL video controllers (physical + virtual)
   - Code was picking first entry which was virtual adapter
   - No filtering for "Virtual Desktop", remote desktop adapters, etc.

Solutions:
1. Applied utils.ApplyNoWindow() to all Windows detection commands
   - Hides wmic, nvidia-smi command windows
   - Consistent with benchmark.go and platform.go patterns
   - No-op on Linux/macOS (cross-platform safe)

2. Enhanced GPU Detection with Virtual Adapter Filtering
   - Iterate through ALL video controllers from wmic
   - Filter out virtual/software adapters:
     * Virtual Desktop adapters
     * Microsoft Basic Display Adapter
     * Remote desktop (VNC, Parsec, TeamViewer)
   - Return first physical GPU (AMD/NVIDIA/Intel)
   - Debug logging shows skipped virtual adapters

Implementation:
- Import internal/utils in sysinfo package
- ApplyNoWindow() on 4 Windows commands:
  * wmic cpu get name,maxclockspeed
  * nvidia-smi --query-gpu=name,driver_version
  * wmic path win32_VideoController get name,driverversion
  * wmic computersystem get totalphysicalmemory
- Enhanced GPU parser with virtual adapter blacklist
- Debug logging for skipped/detected GPUs

Impact:
- No command windows during benchmark initialization (discreet operation)
- Correct physical GPU detection on systems with virtual adapters
- Should properly detect Jake's AMD R7 900 XTX

Files Changed:
- internal/sysinfo/sysinfo.go: ApplyNoWindow + GPU filtering

Reported-by: Jake (4 command prompts, wrong GPU detection)
Tested-on: Linux (build successful, no regressions)
 2025-12-28 19:32:15 -05:00
Stu Leak
f0db050d30 Format cleanup and minor fixes 
- Apply go formatting across internal packages
- Clean up imports and code style
 2025-12-23 21:56:47 -05:00
Stu Leak
54c50e7336 Add sysinfo package for benchmark hardware detection 2025-12-20 13:46:08 -05:00