Prevent CRF control from showing in non-CRF modes
This commit is contained in:
parent
97cad9eeba
commit
c9e34815da
1
DONE.md
1
DONE.md
|
|
@ -825,6 +825,7 @@ This file tracks completed features, fixes, and milestones.
|
||||||
- ✅ Default bitrate preset set to 2.5 Mbps and added 2.0 Mbps option
|
- ✅ Default bitrate preset set to 2.5 Mbps and added 2.0 Mbps option
|
||||||
- ✅ Default encoder preset set to slow
|
- ✅ Default encoder preset set to slow
|
||||||
- ✅ Bitrate mode now strictly hides unrelated controls (CRF only in CRF mode)
|
- ✅ Bitrate mode now strictly hides unrelated controls (CRF only in CRF mode)
|
||||||
|
- ✅ Removed CRF visibility toggle from quality updates to prevent CBR/VBR bleed-through
|
||||||
- ✅ Stabilized video seeking and embedded rendering
|
- ✅ Stabilized video seeking and embedded rendering
|
||||||
- ✅ Improved player window positioning
|
- ✅ Improved player window positioning
|
||||||
- ✅ Fixed clear video functionality
|
- ✅ Fixed clear video functionality
|
||||||
|
|
|
||||||
1
TODO.md
1
TODO.md
|
|
@ -58,6 +58,7 @@ This file tracks upcoming features, improvements, and known issues.
|
||||||
- Default bitrate preset set to 2.5 Mbps with added 2.0 Mbps option
|
- Default bitrate preset set to 2.5 Mbps with added 2.0 Mbps option
|
||||||
- Default encoder preset set to slow
|
- Default encoder preset set to slow
|
||||||
- Bitrate mode hides unrelated controls (CRF only in CRF mode)
|
- Bitrate mode hides unrelated controls (CRF only in CRF mode)
|
||||||
|
- CRF visibility no longer overridden by quality updates
|
||||||
|
|
||||||
*Last Updated: 2025-12-20*
|
*Last Updated: 2025-12-20*
|
||||||
|
|
||||||
|
|
|
||||||
8
main.go
8
main.go
|
|
@ -6702,7 +6702,6 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
|
||||||
updateQualityVisibility = func() {
|
updateQualityVisibility = func() {
|
||||||
hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") ||
|
hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") ||
|
||||||
strings.EqualFold(state.convert.VideoCodec, "H.265")
|
strings.EqualFold(state.convert.VideoCodec, "H.265")
|
||||||
hideCRF := strings.EqualFold(state.convert.Quality, "Lossless")
|
|
||||||
|
|
||||||
if qualitySectionSimple != nil {
|
if qualitySectionSimple != nil {
|
||||||
if hide {
|
if hide {
|
||||||
|
|
@ -6718,13 +6717,6 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
|
||||||
qualitySectionAdv.Show()
|
qualitySectionAdv.Show()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if crfContainer != nil {
|
|
||||||
if hideCRF {
|
|
||||||
crfContainer.Hide()
|
|
||||||
} else {
|
|
||||||
crfContainer.Show()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Simple mode options - minimal controls, aspect locked to Source
|
// Simple mode options - minimal controls, aspect locked to Source
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user