Prevent CRF control from showing in non-CRF modes

This commit is contained in:
Stu Leak 2025-12-20 15:52:36 -05:00
parent 97cad9eeba
commit c9e34815da
3 changed files with 2 additions and 8 deletions

View File

@ -825,6 +825,7 @@ This file tracks completed features, fixes, and milestones.
- ✅ Default bitrate preset set to 2.5 Mbps and added 2.0 Mbps option
- ✅ Default encoder preset set to slow
- ✅ Bitrate mode now strictly hides unrelated controls (CRF only in CRF mode)
- ✅ Removed CRF visibility toggle from quality updates to prevent CBR/VBR bleed-through
- ✅ Stabilized video seeking and embedded rendering
- ✅ Improved player window positioning
- ✅ Fixed clear video functionality

View File

@ -58,6 +58,7 @@ This file tracks upcoming features, improvements, and known issues.
- Default bitrate preset set to 2.5 Mbps with added 2.0 Mbps option
- Default encoder preset set to slow
- Bitrate mode hides unrelated controls (CRF only in CRF mode)
- CRF visibility no longer overridden by quality updates
*Last Updated: 2025-12-20*

View File

@ -6702,7 +6702,6 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
updateQualityVisibility = func() {
hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") ||
strings.EqualFold(state.convert.VideoCodec, "H.265")
hideCRF := strings.EqualFold(state.convert.Quality, "Lossless")
if qualitySectionSimple != nil {
if hide {
@ -6718,13 +6717,6 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject {
qualitySectionAdv.Show()
}
}
if crfContainer != nil {
if hideCRF {
crfContainer.Hide()
} else {
crfContainer.Show()
}
}
}
// Simple mode options - minimal controls, aspect locked to Source