Default target aspect to Source unless user-set

This commit is contained in:
Stu Leak 2025-12-20 14:29:56 -05:00
parent faf8d42e2a
commit ba1c364113
3 changed files with 7 additions and 3 deletions

View File

@ -772,6 +772,7 @@ This file tracks completed features, fixes, and milestones.
- ✅ History sidebar refreshes when jobs complete (snippet entries now appear)
- ✅ Benchmark errors now show non-blocking notifications instead of OK popups
- ✅ Fixed stats bar updates to run on the UI thread to avoid Fyne warnings
- ✅ Defaulted Target Aspect Ratio back to Source unless user explicitly sets it
- ✅ Stabilized video seeking and embedded rendering
- ✅ Improved player window positioning
- ✅ Fixed clear video functionality

View File

@ -46,6 +46,7 @@ This file tracks upcoming features, improvements, and known issues.
- Snippet history updates in sidebar
- Non-blocking benchmark error notifications
- Stats bar updates run on the UI thread
- Target aspect default enforced as Source unless user changes it
## Priority Features for dev20+

View File

@ -531,11 +531,13 @@ func loadPersistedConvertConfig() (convertConfig, error) {
if err := json.Unmarshal(data, &cfg); err != nil {
return cfg, err
}
if cfg.OutputAspect == "" {
if cfg.OutputAspect == "" || strings.EqualFold(cfg.OutputAspect, "Source") {
cfg.OutputAspect = "Source"
cfg.AspectUserSet = false
} else if !cfg.AspectUserSet {
// Treat legacy saved aspects (like 16:9 defaults) as unset
cfg.OutputAspect = "Source"
cfg.AspectUserSet = false
} else if !strings.EqualFold(cfg.OutputAspect, "Source") {
cfg.AspectUserSet = true
}
// Always default FrameRate to Source if not set to avoid unwanted conversions
if cfg.FrameRate == "" {