From 88b318c5e474142cd159b845e9a191d0dabe5907 Mon Sep 17 00:00:00 2001 From: Stu Leak Date: Mon, 29 Dec 2025 00:13:24 -0500 Subject: [PATCH] Fix nil pointer crash in Convert module benchmark indicator MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When benchmark settings are already applied, benchmarkIndicator is nil but was being added to the container unconditionally, causing a crash during UI layout. Changes: - Conditionally build back bar items array - Only append benchmarkIndicator if it's not nil - Prevents SIGSEGV when opening Convert module with applied benchmark 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- main.go | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/main.go b/main.go index fdff53c..41e5cdb 100644 --- a/main.go +++ b/main.go @@ -6318,15 +6318,19 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject { } } - backBar := ui.TintedBar(convertColor, container.NewHBox( + // Build back bar with optional benchmark indicator + backBarItems := []fyne.CanvasObject{ back, layout.NewSpacer(), navButtons, layout.NewSpacer(), - benchmarkIndicator, - cmdPreviewBtn, - queueBtn, - )) + } + if benchmarkIndicator != nil { + backBarItems = append(backBarItems, benchmarkIndicator) + } + backBarItems = append(backBarItems, cmdPreviewBtn, queueBtn) + + backBar := ui.TintedBar(convertColor, container.NewHBox(backBarItems...)) var updateCover func(string) var coverDisplay *widget.Label