From 7b264c72249bad2277f4e14d7e5a5e28fef9200d Mon Sep 17 00:00:00 2001 From: Stu Leak Date: Sat, 20 Dec 2025 16:22:48 -0500 Subject: [PATCH] Hide quality presets outside CRF mode --- DONE.md | 1 + TODO.md | 1 + main.go | 5 +++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/DONE.md b/DONE.md index 9b319f9..a3a7ed9 100644 --- a/DONE.md +++ b/DONE.md @@ -830,6 +830,7 @@ This file tracks completed features, fixes, and milestones. - ✅ Added 0.5/1.0 Mbps bitrate presets and simplified preset names - ✅ Default bitrate preset normalized to 2.5 Mbps to avoid "select one" - ✅ Linked simple and advanced bitrate presets so they stay in sync +- ✅ Hide quality presets when bitrate mode is not CRF - ✅ Stabilized video seeking and embedded rendering - ✅ Improved player window positioning - ✅ Fixed clear video functionality diff --git a/TODO.md b/TODO.md index 45eb7e4..9405edd 100644 --- a/TODO.md +++ b/TODO.md @@ -63,6 +63,7 @@ This file tracks upcoming features, improvements, and known issues. - Bitrate presets expanded to include 0.5/1.0 Mbps and renamed for clarity - Default bitrate preset normalized to 2.5 Mbps to prevent empty select - Simple/advanced bitrate presets synced + - Quality presets hidden when bitrate mode is not CRF *Last Updated: 2025-12-20* diff --git a/main.go b/main.go index b572115..d3e5cc3 100644 --- a/main.go +++ b/main.go @@ -6824,16 +6824,17 @@ func buildConvertView(state *appState, src *videoSource) fyne.CanvasObject { updateQualityVisibility = func() { hide := strings.Contains(strings.ToLower(state.convert.SelectedFormat.Label), "h.265") || strings.EqualFold(state.convert.VideoCodec, "H.265") + hideQuality := state.convert.BitrateMode != "" && state.convert.BitrateMode != "CRF" if qualitySectionSimple != nil { - if hide { + if hide || hideQuality { qualitySectionSimple.Hide() } else { qualitySectionSimple.Show() } } if qualitySectionAdv != nil { - if hide { + if hide || hideQuality { qualitySectionAdv.Hide() } else { qualitySectionAdv.Show()