Leak_Technologies/HULL
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: #define DEAD_HEIGHT -8

Browse Source 
From the research conducted in
https://github.com/ioquake/ioq3/issues/794
we can probably conclude that the `self->r.maxs[2] = -8;`
in `player_die()` is related to `pm->maxs[2] = -8;`
in `PM_CheckDuck()`. Let's make this clear with a named constant.
This commit is contained in:
WofWca 2025-11-06 12:25:12 +04:00 committed by Tim Angus
parent 3041ec3695
commit 38c4180740
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
code/game/bg_pmove.c
View File

@ -1275,7 +1275,7 @@ static void PM_CheckDuck (void)
if (pm->ps->pm_type == PM_DEAD) if (pm->ps->pm_type == PM_DEAD)
{ {
pm->maxs[2] = -8; pm->maxs[2] = DEAD_HEIGHT;
pm->ps->viewheight = DEAD_VIEWHEIGHT; pm->ps->viewheight = DEAD_VIEWHEIGHT;
return; return;
} }

1
code/game/bg_public.h
View File

@ -52,6 +52,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#define DEFAULT_VIEWHEIGHT 26 #define DEFAULT_VIEWHEIGHT 26
#define CROUCH_HEIGHT 16 #define CROUCH_HEIGHT 16
#define CROUCH_VIEWHEIGHT 12 #define CROUCH_VIEWHEIGHT 12
#define DEAD_HEIGHT -8
#define DEAD_VIEWHEIGHT -16 #define DEAD_VIEWHEIGHT -16
// //

2
code/game/g_combat.c
View File

@ -601,7 +601,7 @@ void player_die( gentity_t *self, gentity_t *inflictor, gentity_t *attacker, int
self->s.loopSound = 0; self->s.loopSound = 0;
self->r.maxs[2] = -8; self->r.maxs[2] = DEAD_HEIGHT;
// don't allow respawn until the death anim is done // don't allow respawn until the death anim is done
// g_forcerespawn may force spawning at some later time // g_forcerespawn may force spawning at some later time